feat: use clientcmd.ConfigOverrides for kubeconfig #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
force-pushed
the
feat/kubeconfig-overwrites
branch
from
069c38e to
b605ba3
Compare
with k8s 1.30 it is possible to use clientcmd.NewDefaultClientConfig to merge an existing clientcmdapi.Config with ConfigOverrides.
IvoGoman
force-pushed
the
feat/kubeconfig-overwrites
branch
from
b605ba3 to
a8764c1
Compare
kengou
approved these changes
Nov 4, 2024
kengou
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Can you please check and fix the failed test ? https://github.com/cloudoperators/greenhouse/actions/runs/11661495679/job/32527935794?pr=448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with k8s 1.30 it is possible to use clientcmd.NewDefaultClientConfig to merge an existing clientcmdapi.Config with ConfigOverrides.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist