Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): kubeconfig registry controller #526

Merged
merged 24 commits into from
Oct 15, 2024
Merged

feat(core): kubeconfig registry controller #526

merged 24 commits into from
Oct 15, 2024

Conversation

onuryilmaz
Copy link
Contributor

@onuryilmaz onuryilmaz commented Sep 4, 2024 •
edited
Loading

It adds a controller to create & update kubeconfig resources based on the cluster, organization and their related secrets.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added documentation Improvements or additions to documentation feature core-apis helm-charts dependencies labels Sep 4, 2024
@onuryilmaz onuryilmaz marked this pull request as ready for review September 5, 2024 11:33
@onuryilmaz onuryilmaz requested a review from a team as a code owner September 5, 2024 11:33
@onuryilmaz onuryilmaz mentioned this pull request Sep 5, 2024
Closed
@onuryilmaz
Copy link
Contributor Author

thanks and kudos to @Nuckal777 for previous work on kubeconfig-generator

IvoGoman
IvoGoman requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@IvoGoman IvoGoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the GH notification, sorry for the slow response

pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Outdated Show resolved Hide resolved
pkg/controllers/cluster/suite_test.go Outdated Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Outdated Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
uwe-mayer
uwe-mayer requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@uwe-mayer uwe-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Some remarks on status reporting

pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Outdated Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Outdated Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Outdated Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
pkg/controllers/cluster/kubeconfig_controller.go Show resolved Hide resolved
@onuryilmaz
Copy link
Contributor Author

@uwe-mayer I have fixed & resolved most of the conversations, please have another look when you have time 👍

@IvoGoman IvoGoman force-pushed the feat/kubeconfig-registry-controller branch from 7174f9f to ea0e52e Compare October 10, 2024 14:40
@IvoGoman IvoGoman requested a review from uwe-mayer October 10, 2024 14:41
@IvoGoman IvoGoman force-pushed the feat/kubeconfig-registry-controller branch from e8fa00a to 9b13e68 Compare October 11, 2024 12:20
@IvoGoman IvoGoman force-pushed the feat/kubeconfig-registry-controller branch from 25594e0 to bd165f9 Compare October 11, 2024 14:19
@IvoGoman IvoGoman merged commit 75babf1 into main Oct 15, 2024
@IvoGoman IvoGoman deleted the feat/kubeconfig-registry-controller branch October 15, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uwe-mayer uwe-mayer uwe-mayer approved these changes

@Nuckal777 Nuckal777 Nuckal777 left review comments

@IvoGoman IvoGoman IvoGoman approved these changes

Assignees
No one assigned
Labels
core-apis dependencies documentation Improvements or additions to documentation feature helm-charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onuryilmaz @IvoGoman @Nuckal777 @uwe-mayer