generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(teammemberships): refactor SCIM pkg #792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijith-darshan
changed the title
feat(scim) - refactor SCIM pkg
feat(teammemberships) - refactor SCIM pkg
Dec 10, 2024
abhijith-darshan
changed the title
feat(teammemberships) - refactor SCIM pkg
feat(teammemberships): refactor SCIM pkg
Dec 10, 2024
IvoGoman
requested changes
Dec 13, 2024
Co-authored-by: IvoGoman <[email protected]>
organization controller checks for group exists with len check and corresponding not available condition
IvoGoman
previously approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🚀
kengou
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
Organization
controller andTeamMembership
controller both use SCIM API to -The SCIM pkg is refactored to reduce the number of calls being made to the SCIM endpoint.
The Organization controller will check if a Group exists by searching for the provided IDP Group and will not attempt to list members as it is not needed
The TeamMembership controller will list all Users for the provided IDP Group (With Pagination)
SCIM Pkg is refactored:
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Unit Tests are added and subsequent unit tests for
Organization
andTeamMembership
is updatedAdded to documentation?
Checklist