generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(teams): add members to team status #794
Draft
gciezkowski-acc
wants to merge
6
commits into
main
Choose a base branch
from
feat/723_team_controller_store_members
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
core-apis
documentation
Improvements or additions to documentation
labels
Dec 10, 2024
gciezkowski-acc
force-pushed
the
feat/723_team_controller_store_members
branch
from
December 10, 2024 12:12
b9cefbe
to
1affb21
Compare
Comment on lines
+73
to
+81
func hasOwnerReference(ownerReferences []v1.OwnerReference, kind, name string) bool { | ||
for _, ownerReference := range ownerReferences { | ||
if ownerReference.Kind == kind && ownerReference.Name == name { | ||
return true | ||
} | ||
} | ||
|
||
return false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be replaced with
greenhouse/pkg/clientutil/owner_reference.go
Lines 10 to 18 in 2a5d694
// GetOwnerReference returns the OwnerReference if found else nil. | |
func GetOwnerReference(obj metav1.Object, kind string) *metav1.OwnerReference { | |
for _, ref := range obj.GetOwnerReferences() { | |
if ref.Kind == kind { | |
return &ref | |
} | |
} | |
return nil | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add team members to a team status.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist