feat(authN): Redesign JWT token auth #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkrzyz
requested review from
drochow,
MR2011 and
dorneanu
as code owners
michalkrzyz
force-pushed
the
mikrzyz/issue-239
branch
3 times, most recently
from
7240fe3 to
6a63744
Compare
drochow
requested changes
Nov 21, 2024
michalkrzyz
force-pushed
the
mikrzyz/issue-239
branch
from
eb0f0b3 to
7e776e4
Compare
MR2011
approved these changes
Nov 26, 2024
dorneanu
reviewed
Nov 26, 2024
|
In the description I cannot see the "related issues" nor the ones which the PR should close. |
michalkrzyz
changed the title
Redesign JWT token authentication middleware to support additional/alternative authentication method
Split verify function for JWT token auth to make it more readable
michalkrzyz
force-pushed
the
mikrzyz/issue-239
branch
from
7e776e4 to
0c9e99a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign JWT token authentication middleware to support additional/alternative authentication method
Description
Implementation of the capability of having multiple auth mechanisms in place.
To register new auth method (JWT or oidc), function with Verify(c *gin.Context) error has to be implemented.
Currently only JWT token based authentication is used, oidc implementation with it's Verify method will be implemented in separate issue/PR.
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist