feat(authN): change SapID to UniqueUserId (#85) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkrzyz
force-pushed
the
mikrzyz/issue-85
branch
from
9344db8 to
52c7bd1
Compare
MR2011
reviewed
Jul 30, 2024
MR2011
reviewed
Jul 30, 2024
There was a problem hiding this comment.
IMO user_type is fine, do you prefer an enum? @drochow
There was a problem hiding this comment.
I like enforcing on the DB level where possible, but in this case, the probability that we might add other types might favor using no enum here.
MR2011
reviewed
Jul 30, 2024
michalkrzyz
changed the title
6 tasks
michalkrzyz
force-pushed
the
mikrzyz/issue-85
branch
3 times, most recently
from
38ba9f5 to
def4489
Compare
Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and human user
michalkrzyz
force-pushed
the
mikrzyz/issue-85
branch
from
def4489 to
47f6476
Compare
dustindemmerle
pushed a commit
that referenced
this pull request
Aug 6, 2024
* feat(authN): change SapID to UniqueUserId (#85) Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and human user * Automatic application of license header --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: David Rochow <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and casual user Add gqlgen makefile target
Add fmt makefile target