Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(heureka): renames Issues to Vulnerabilities tab with the default filter of issueType is Vulnerability #660

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

hodanoori
Copy link
Contributor

Summary

This pull request introduces a default filter of issueType=Vulnerability to the issueMatches entity, ensuring that only vulnerabilities associated with various images are displayed on this view. Additionally, related text updates have been implemented for consistency and clarity.

Changes Made

  • Tab Update: The "Issues" tab has been renamed to "Vulnerabilities" for better alignment with the content displayed.
  • Detail Panel Simplification: The issueType field has been removed from the details panel since the view now applies a default issueType=Vulnerability filter.
  • Text Adjustments: "Not found" messages have been updated to reference "vulnerabilities" instead of "issues" and "images" instead of "components" to improve clarity.
  • Filter Option Adjustment: The issueType filter option has been removed from the proposed filter select list, reflecting the default filtering logic applied.
  • Function Enhancement: The setQueryOption function has been modified to merge new queryOptions with the existing ones rather than replacing them entirely.

Related Issues

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@hodanoori hodanoori requested a review from a team as a code owner December 4, 2024 14:48
Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: ff1ef3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hodanoori hodanoori self-assigned this Dec 4, 2024
@hodanoori hodanoori added the heureka Heureka related issues label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-10 15:52 UTC

@hodanoori hodanoori changed the title chore(heureka): shows only vulnerabilities from issueMatches entity chore(heureka): renames Issues to Vulnerabilities tab with the default filter of issueType=Vulnerability Dec 4, 2024
@hodanoori hodanoori changed the title chore(heureka): renames Issues to Vulnerabilities tab with the default filter of issueType=Vulnerability chore(heureka): renames Issues to Vulnerabilities tab with the default filter of issueType is Vulnerability Dec 4, 2024
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment as a question

Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please ask someone to review it proper

Copy link
Contributor

@TilmanHaupt TilmanHaupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks logical to me!

@hodanoori hodanoori merged commit d07a3cb into main Dec 10, 2024
15 checks passed
@hodanoori hodanoori deleted the heureka-add-vulnerability-filter branch December 10, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
heureka Heureka related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants