feature: added ability to set the attributes block_public_acls and ig…

[Faris96Hub]

…nore_public_acls for the origin bucket

what

• added optional variables block_public_acls and ignore_public_acls to be able to set those attributes in the resource "aws_s3_bucket_public_access_block". The default is set to true to match the current module config.

why

• Needed to be able to make the origin bucket optionally publicly accessable

references

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates the S3 bucket public access configuration by replacing hardcoded boolean values with variable references. In the main configuration file, the public access block now uses variables for ACL settings. Additionally, the changes introduce two new boolean variables in the variables file to enable external control over the public ACL behavior for the S3 origin bucket.

Changes

File	Change Summary
main.tf	Updated the aws_s3_bucket_public_access_block resource by replacing hardcoded ACL values (true) with variable references (var.block_public_acls and var.ignore_public_acls), and updated the accompanying comment for clarity.
variables.tf	Added two new boolean variables, block_public_acls and ignore_public_acls, each with a default value of true and descriptions explaining their roles in controlling public ACL settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8853705 and c68019a.

📒 Files selected for processing (2)

• main.tf (1 hunks)
• variables.tf (1 hunks)

🔇 Additional comments (2)

variables.tf (1)

564-575: New Public Access Variables Added

The addition of the block_public_acls and ignore_public_acls variables provides the desired flexibility, allowing users to configure whether the S3 origin bucket should block or consider public ACLs. The default values of true maintain a secure configuration by default. Consider a minor nit: refining the descriptions (e.g., "When set to false, the S3 origin bucket permits public ACLs") for improved clarity.

main.tf (1)

389-392: Configurable ACL Settings in Public Access Block Resource

Replacing the hardcoded boolean values with var.block_public_acls and var.ignore_public_acls in the aws_s3_bucket_public_access_block resource correctly exposes configuration control to the user. This change aligns with the PR’s goal of providing optional overrides for ACL settings. It would be beneficial to ensure that the module documentation is updated to reflect this new flexibility.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[RoseSecurity]

Cloud Posse modules are designed to be secure by default. However, I’m curious about the use cases for toggling these parameters to false. I’m trying to understand the security implications of this and whether it’s worth exposing these options.