This repository was archived by the owner on May 3, 2023. It is now read-only.
Fix IAM policy error, make some stuff configurable #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nners_name for runner ASG name, change local.runners_ssm_token_key into a variable
…ycle expiration days
![nullify-app[bot]](https://avatars.githubusercontent.com/u/46980107?s=60&v=4){kind=small}
| policy = data.template_file.instance_profile.rendered | ||
| name_prefix = "gitlab-runner-instance-role" | ||
| role = aws_iam_role.instance.name | ||
| policy = data.template_file.instance_profile.rendered | ||
| } | ||
|
|
||
| resource "aws_cloudwatch_log_group" "environment" { |
There was a problem hiding this comment.
This could potentially be a aws-cloudwatch-log-group-customer-key vulnerability which is of LOW severity.
Message: CloudWatch log groups should be encrypted using CMK
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found this module to be incredibly helpful but somewhat limiting with how many of the options weren't configurable. I've also run into an issue where the runner instance wasn't able to create spot requests due to
ec2:AuthorizeSecurityGroupIngressmissing in its IAM policy.I'm not so sure about the default for the new variable
tags. Perhaps just remove the default?