Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run_clang_format.py): Add early return for empty formatted_filenames in check() #789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hao0012
Copy link

@hao0012 hao0012 commented Dec 25, 2024

If formatted_filenames is empty, it will run clang-format with the -i flag on an empty list, resulting error: cannot use -i when reading from stdin

DO NOT PUSH PROJECT SOLUTIONS PUBLICLY.

And especially do NOT open pull requests with project solutions!

Please be considerate of this free educational resource.

…ames` in check function.

If `formatted_filenames` is empty, it will run `clang-format` with the `-i` flag on an empty list, resulting `error: cannot use -i when reading from stdin`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant