Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Labels for Tiers #238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ana-dashuk-cobalt
Copy link
Contributor

@ana-dashuk-cobalt ana-dashuk-cobalt commented Nov 23, 2022

Changelog

Added

Test PR. Added labels showing PtaaS tiers. @mjang-cobalt

I found this code somewhere and modified. It's not the best possible syntax, but it works.

https://deploy-preview-238--cobalt-docs.netlify.app/platform-deep-dive/pentests/reports/customize-report/

Screenshot 2022-11-23 at 14 30 49

Another possible use of labels:

https://deploy-preview-238--cobalt-docs.netlify.app/platform-deep-dive/credits/ptaas-tiers/

Screenshot 2022-11-23 at 17 22 56

Preview This Change

To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like https://deploy-preview-<num>--cobalt-docs.netlify.app/

Variables

Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:

{{% asset-categories %}}

You’ve found a shortcode that we include in multiple documents.

You’ll find the content of the shortcode in the following directory:

https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes

That shortcode has the same base name as what you see in the PR, such as asset-categories.html.

Checklist for PR Author

[ ] Did you check for broken links and alt text?

Be sure to check for broken links and Alt Text issues. We have a partially automated process,
as described in this section of our repository README:
Test Links and Alt Attributes.

@ana-dashuk-cobalt ana-dashuk-cobalt self-assigned this Nov 23, 2022
@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for cobalt-docs ready!

Name Link
🔨 Latest commit 9dead02
🔍 Latest deploy log https://app.netlify.com/sites/cobalt-docs/deploys/6385ea2072b4980009f9f426
😎 Deploy Preview https://deploy-preview-238--cobalt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ana-dashuk-cobalt ana-dashuk-cobalt marked this pull request as ready for review November 25, 2022 10:18
@@ -12,7 +12,7 @@ We offer three [PtaaS tiers](https://www.cobalt.io/pentest-pricing) to best suit

To get started, check our [pricing model](https://www.cobalt.io/pentest-pricing), and select a plan that matches your testing expectations and business needs.

| Standard | Premium | Enterprise |
| <span style="border-radius:10px;-webkit-border-radius:10px;-moz-border-radius:10px;background-color:#4185EB;padding:10px;text-align:center;opacity:75%;"><span style="color: #FFFFFF;font-weight:bold;">Standard</span></span> | <span style="border-radius:10px;-webkit-border-radius:10px;-moz-border-radius:10px;background-color:#8E3EDB;padding:10px;text-align:center;opacity:75%;"><span style="color: #FFFFFF;font-weight:bold;">Premium</span></span> | <span style="border-radius:10px;-webkit-border-radius:10px;-moz-border-radius:10px;background-color:#0DB285;padding:10px;text-align:center;opacity:75%;"><span style="color: #FFFFFF;font-weight:bold;">Enterprise</span></span> |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brainstorming... Is it possible to set up a shortcode for each label?

  • Alternative: we'll need a place to "copy/paste" the HTML for each label, maybe even the confluence page for the UI Style Guide.

Maybe we should also chat with a designer? Post this idea in an internal Slack channel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjang-cobalt I added shortcodes for labels, they work.

Alternative: we'll need a place to "copy/paste" the HTML for each label, maybe even the confluence page for the UI Style Guide.

I didn't understand why we need these labels in the UI Text Style Guide.

Maybe we should also chat with a designer? Post this idea in an internal Slack channel?

How can designers help us? If they suggest a different look and feel, I may not be able to handle it technically.

Initially, I thought we don't need to add these labels to each page. We can only add them to the pages describing Premium or Enterprise features: Jira and GitHub integrations and customizable reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants