Migration to Patternfly v6 #21611
Draft
Migration to Patternfly v6 #21611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
added
the
no-test
jelly
reviewed
Feb 12, 2025
| <Toolbar className="ct-alert-toolbar"> | ||
| <ToolbarContent> | ||
| <ToolbarGroup spaceItems={{ default: "spaceItemsMd" }}> |
There was a problem hiding this comment.
So this no longer does any layout, what replaces this?
There was a problem hiding this comment.
IIRC I changed this after messing about with the wrap issue. Can check soon
|
|
||
| // REVIEW @Venefilyn: Is this still true? | ||
| /* Import our own fonts since the PF4 font-face rules are filtered out in build.js */ |
There was a problem hiding this comment.
This is a good first prio target :)
Venefilyn
force-pushed
the
pf6
branch
2 times, most recently
from
243148a to
4bc7573
Compare
TODO: Add documentation about this
`npx @patternfly/class-name-updater ./pkg --v6 --fix`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP while we work through what can be skipped, what can be improved before merging, and what is fine to merge. Treat as a spike for #21611
To redo codemod simply reset the commit, revert changes you don't want, and run
button-moveIcons-icon-propis excluded as it only makes it have a small margin (can be added later)menuToggle-warn-iconOnly-togglesame as above icon exclusionhelperTextItem-warn-screenReaderText-updateis excluded for now as things should work still for most casesItems fixed or documented
When we are about to merge these should all be on our minds so we can fix either in this or preferably in upcoming PRs
<Content>, need to be verified manually post-merge TextContent + Text results in two Content components patternfly/pf-codemods#825@patternfly/patternfly/*-theme-dark.cssstuff is removed due to PF Tokensreminstead--pf-v5-global--spacer--need to be renamed to--pf-t--global--spacer--EmptyStateIconPropsandEmptyStateHeaderPropsare merged intoEmptyStatePropsiframesusePagecomponent as it should but we need an override to prevent whitespace in its grid Page - Allow main grid without sidebar and masthead patternfly/patternfly#7357--pf-t--global--icon--color--status--info--defaultAll new upstream issues deriving from this upgrade
Related PRs