Skip to content

colenc: harden TestEncoderEqualityRand #146254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

yuzefovich
Copy link
Member

We just saw a failure in this test due to hitting spanconfig.tenant_limit (5k by default) since the test creates 100 tables without dropping them, and some of those tables might have partitions. This commit simply increases the limit by 10x (similar to what we do in mixed-version roachtest framework).

Fixes: #146057.

Release note: None

We just saw a failure in this test due to hitting
`spanconfig.tenant_limit` (5k by default) since the test creates 100
tables without dropping them, and some of those tables might have
partitions. This commit simply increases the limit by 10x (similar to
what we do in mixed-version roachtest framework).

Release note: None
@yuzefovich yuzefovich requested a review from a team as a code owner May 7, 2025 02:55
@yuzefovich yuzefovich added the backport-all Flags PRs that need to be backported to all supported release branches label May 7, 2025
@yuzefovich yuzefovich requested review from DrewKimball and removed request for a team May 7, 2025 02:55
@yuzefovich yuzefovich added the backport-25.2.x Flags PRs that need to be backported to 25.2 label May 7, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@yuzefovich
Copy link
Member Author

blathers backport release-25.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-25.2.x Flags PRs that need to be backported to 25.2 backport-all Flags PRs that need to be backported to all supported release branches target-release-25.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/sql/colenc/colenc_test: TestEncoderEqualityRand failed
3 participants