roachtest/pg_regress: improve the runner a bit #146256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes one RegEx added last week as well as modifies `type_sanity.sql` patch to add ORDER BY clause to make the output deterministic (PG returns no rows so it doesn't need that). Release note: None
yuzefovich
requested review from
a team and
mgartner
and removed request for
a team
yuzefovich
requested review from
golgeek and
DarrylWong
and removed request for
a team
|
This change is |
mgartner
approved these changes
May 7, 2025
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes one RegEx added last week as well as modifies
type_sanity.sqlpatch to add ORDER BY clause to make the output deterministic (PG returns no rows so it doesn't need that).Fixes: #146025.
Release note: None