opt: use filters from scanIndexIter in TryGenerateVectorSearch #146259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the `TryGenerateVectorSearch` exploration rule to use the filters provided by `scanIndexIter.ForEach` rather than those originally supplied to `TryGenerateVectorSearch`. This fixes two bugs: 1. Now, each iteration no longer overwrites the filters, ensuring that the iteration for each index sees the correct set of filters. 2. The rule can now apply when the filters exactly match the partial-index predicate, if any. Fixes cockroachdb#146257 Fixes cockroachdb#146258 Release note (bug fix): Fixed a bug in v25.1.0 where a vector search operator could drop user-supplied filters if the same vector column was indexed twice and an index with no prefix columns was defined after one with prefix columns.
|
This change is |
DrewKimball
added
the
backport-25.2.x
yuzefovich
approved these changes
May 7, 2025
There was a problem hiding this comment.
Nice catch!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
-- commits line 15 at r1:
nit: s/25.1.0/25.2.0/.
pkg/sql/opt/xform/limit_funcs.go line 461 at r1 (raw file):
// 2. A lookup-join to retrieve the vector column and any other needed columns. // 3. A projection of the distance between the vector column and query vector. // 3. A top-k operator to perform re-ranking.
nit: should this be 4?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the
TryGenerateVectorSearchexploration rule to use the filters provided byscanIndexIter.ForEachrather than those originally supplied toTryGenerateVectorSearch. This fixes two bugs:Fixes #146257
Fixes #146258
Release note (bug fix): Fixed a bug in v25.1.0 where a vector search operator could drop user-supplied filters if the same vector column was indexed twice and an index with no prefix columns was defined after one with prefix columns.