rpc,server: port server interceptors to drpc #148256
Draft
+520
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
As part of migration from grpc to drpc, we need to migrate all the server interceptors within the cockroachdb to their drpc variants. Here, we move multiple interceptors 1)Stopper interceptor, 2)Metrics recorder, 3)Access control filtering interceptor. Existing metrics recorder logic is refactored with factory methods to generate two variants (grpc, drpc) of metrics interceptor. Epic: CRDB-49357 Fixes: cockroachdb#144373 Part of: CRDB-49359 Release note: None
shaikzakiriitm
force-pushed
the
port-server-interceptors
branch
from
9e4f9e8 to
ee9e332
Compare
As part of drpc migration, server side tracing interceptors are ported to drpc as part of this change. Common logic used in both grpc/drpc tracing server interceptors are moved to tracing/utils.go for reusability. Drpc tracing interceptor is injected into the drpc server. Epic: CRDB-51562 Fixes: cockroachdb#148350 Part of: CRDB-49359 Release note: None
<what was there before: Previously, ...> Adding authentication and authorization server interceptor for drpc server. Epic: CRDB-49353 Fixes: cockroachdb#144369 Part of: CRDB-49359 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of migration from grpc to drpc, we need to migrate all the server interceptors within the cockroachdb to their drpc variants.
Here, we move multiple interceptors 1)Stopper interceptor, 2)Metrics recorder, 3)Access control filtering interceptor. Existing metrics recorder logic is refactored with factory methods to generate two variants (grpc, drpc) of metrics interceptor.
Note: This pr uses the changes from cockroachdb/drpc#7
Epic: CRDB-49357
Fixes: #144373
Part of: CRDB-49359
Release note: None