Skip to content

Add docs on CREATE SEQUENCE PER NODE CACHE #19747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-9830

Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit e0e8164
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6853213827eb7d00085de0d9

Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit e0e8164
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/685321384db2f10008b47685

@rmloveland
Copy link
Contributor Author

docs for cockroachdb/cockroach#118546

Copy link

netlify bot commented Jun 10, 2025

Netlify Preview

Name Link
🔨 Latest commit e0e8164
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68532138b18ec4000810ad3c
😎 Deploy Preview https://deploy-preview-19747--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland rmloveland requested a review from rafiss June 10, 2025 18:08
@rmloveland
Copy link
Contributor Author

@rafiss just updated with your feedback, PTAL!

PS if you know offhand which versions this is in, I will backport these changes once they look ok. If you don't know offhand I can check the git history, no worries

@rmloveland
Copy link
Contributor Author

@rafiss i see you are on PTO, since I have updated this based on your previous feedback I will move it along to docs team review on the theory it's better out there for customers vs. waiting - thank you for the review!

@rmloveland rmloveland requested a review from taroface June 17, 2025 15:31
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, formatting nits

@rmloveland
Copy link
Contributor Author

thanks for the reviews! backporting to all supported versions v24.1 and later per this command (SHA from https://github.com/cockroachdb/cockroach/pull/118546/commits)

$ git tag --contains=e4db1bec055b3e6d4a81e7e21723664f4acc0086 | grep 'v2{4,5}'
v24.1.0
v24.1.0-alpha.2
v24.1.0-alpha.3
v24.1.0-alpha.4
v24.1.0-alpha.5
v24.1.0-beta.1
v24.1.0-beta.2
v24.1.0-beta.3
v24.1.0-rc.1
v24.1.0-rc.2
v24.1.1
v24.1.10
v24.1.11
v24.1.12
v24.1.13
v24.1.14
v24.1.15
v24.1.16
v24.1.17
v24.1.18
v24.1.19
v24.1.2
v24.1.3
v24.1.4
v24.1.5
v24.1.6
v24.1.7
v24.1.8
v24.1.9
v24.2.0
v24.2.0-alpha.1
v24.2.0-alpha.2
v24.2.0-beta.1
v24.2.0-beta.2
v24.2.0-beta.3
v24.2.0-rc.1
v24.2.1
v24.2.10
v24.2.2
v24.2.3
v24.2.4
v24.2.5
v24.2.6
v24.2.7
v24.2.8
v24.2.9
v24.3.0
v24.3.0-alpha.1
v24.3.0-alpha.2
v24.3.0-beta.1
v24.3.0-beta.2
v24.3.0-beta.3
v24.3.0-rc.1
v24.3.1
v24.3.10
v24.3.11
v24.3.12
v24.3.13
v24.3.14
v24.3.2
v24.3.3
v24.3.4
v24.3.5
v24.3.6
v24.3.7
v24.3.8
v24.3.9
v25.1.0
v25.1.0-alpha.1
v25.1.0-alpha.2
v25.1.0-alpha.3
v25.1.0-beta.1
v25.1.0-beta.2
v25.1.0-beta.3
v25.1.0-rc.1
v25.1.1
v25.1.2
v25.1.3
v25.1.4
v25.1.5
v25.1.6
v25.1.7
v25.2.0
v25.2.0-alpha.1
v25.2.0-alpha.2
v25.2.0-alpha.3
v25.2.0-beta.1
v25.2.0-beta.2
v25.2.0-beta.3
v25.2.0-rc.1
v25.2.1
v25.3.0-alpha.1
v25.3.0-alpha.2

Fixes DOC-9830

NB. This change applied to all supported versions v24.1+
@rmloveland rmloveland force-pushed the 20250610-DOC-9830-per-node-sequence-cache branch from 3b7d98f to e0e8164 Compare June 18, 2025 20:27
@rmloveland rmloveland enabled auto-merge (squash) June 18, 2025 20:27
@rmloveland rmloveland merged commit 6f37558 into main Jun 18, 2025
7 checks passed
@rmloveland rmloveland deleted the 20250610-DOC-9830-per-node-sequence-cache branch June 18, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants