Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add new patterns for vulnerability scanning [TAROT-2791] #87

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

afsmeira
Copy link
Collaborator

@afsmeira afsmeira commented Sep 2, 2024

You can ignore changes inside the multiple-tests folder. These are integration tests that run the tool as an analysis would and given the dependency files will produce the results in the XML.

@afsmeira afsmeira force-pushed the feat/tarot2791 branch 3 times, most recently from fd9562e to 18b6c5d Compare September 2, 2024 10:40
@afsmeira afsmeira force-pushed the feat/tarot2791 branch 2 times, most recently from 856d7d7 to 1539afd Compare September 2, 2024 14:39
@afsmeira
Copy link
Collaborator Author

afsmeira commented Sep 2, 2024

@lorandszakacs when this is merged and incorporated in codacy-tools you will need to change https://github.com/codacy/codacy-worker/pull/868 and add two new patterns: vulnerability_medium and vulnerability_minor.

@afsmeira
Copy link
Collaborator Author

afsmeira commented Sep 2, 2024

@lventura-codacy please take a look at the documentation and pattern names and suggest any changes you'd like.

Copy link

@lventura-codacy lventura-codacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicky suggestions on the docs, otherwise LGTM

docs/description/vulnerability.md Outdated Show resolved Hide resolved
docs/description/vulnerability_medium.md Outdated Show resolved Hide resolved
docs/description/vulnerability_minor.md Outdated Show resolved Hide resolved
@afsmeira afsmeira merged commit 8e43671 into master Sep 3, 2024
8 checks passed
@afsmeira afsmeira deleted the feat/tarot2791 branch September 3, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants