dynamic pawn promotion to Q,R,B,N #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siinghd
reviewed
Jun 18, 2024
| } | null)[][]; | ||
| socket: WebSocket; | ||
| }) => { | ||
| console.log('chessboard reloaded'); |
There was a problem hiding this comment.
can we remove the console log?
There was a problem hiding this comment.
i tried to fix the lint issues using yarn format but the main branch doesn't have all files formatted so it changed all the formatting what should i do?
siinghd
requested changes
Jun 19, 2024
| const captureAudio = new Audio(CaptureSound); | ||
| const labels = ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h']; | ||
| const [canvas, setCanvas] = useState<HTMLCanvasElement | null>(null); | ||
| const boxSize = 80; |
There was a problem hiding this comment.
why this boxSize is set directly to 80?
previously was
const boxSize =
width > height
? Math.floor((height - OFFSET) / 8)
: Math.floor((width - OFFSET) / 8);
apps/ws/src/GameManager.ts
Outdated
| @@ -178,7 +191,6 @@ export class GameManager { | |||
|
|
|||
| console.log(availableGame.getPlayer1TimeConsumed()); | |||
There was a problem hiding this comment.
can we remove these console logs?
asutosh-147
force-pushed
the
pawnPromotion
branch
from
143b55e to
84cfdb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#348
chrome_HtDWXq1cw3.mp4
Hii @hkirat , just added this pawn promotion logic, pls review it when you have some time