FEAT/Added Job Management Page #300

dev13-suthar · 2024-09-05T13:29:00Z

->Admin can visit the /manage page and see all list of active jobs, and Delete them As Well.
->From the Action button admin can edit and delete JOBS.
->Admin can Create Post. (redirects to /create Page).
->Fixed Typo in Footer
-> In this PR i have only done Delete Job Functionality which is deactivated because there is no session Management as Now.
Fixes:[#284]

dev13-suthar · 2024-09-10T18:30:13Z

@VineeTagarwaL-code

VineeTagarwaL-code · 2024-09-16T17:24:36Z

Nice pr, can you fix the conflicts and give a video of your functioning

dev13-suthar · 2024-09-17T03:58:48Z

ok

dev13-suthar · 2024-09-17T08:17:40Z

100xJobs.-.Google.Chrome.2024-09-17.13-40-44.mp4

dev13-suthar · 2024-09-17T08:26:16Z

@VineeTagarwaL-code solved conflicts, Fixed UI bug( JOB was being displayed even after deleting until we perform hard reload). tag me once you review this.

VineeTagarwaL-code · 2024-09-17T18:02:13Z

this looks great now, a good starting point can you one more feature where the admin can approve jobs will be really usefull

dev13-suthar · 2024-09-18T03:59:20Z

Yes i can do that, but since there is no session logic, Signup,Register how can i determine logged in User is Admin or Not,? Why there is no signin/signup options?

VineeTagarwaL-code · 2024-09-18T05:05:00Z

can you add that feature here in this PR itself, was gonna open a new one but if you can do it it will be great !

dev13-suthar · 2024-09-18T05:15:54Z

sure i'll take this.
so i have to done signin,signup logic with nextAuth and then add job approval functionality. right?

VineeTagarwaL-code · 2024-09-18T06:02:08Z

yeah it already there the code is not purged

dev13-suthar · 2024-09-19T06:14:52Z

summary:
Added /api/auth/...nextAuth,
cleaned authOptions code so we can use session,
/manage admin only page,
admin can approve Jobs.
video:

Demo.mp4

commit these?

VineeTagarwaL-code · 2024-09-19T07:40:03Z

show auth flow with logout

dev13-suthar · 2024-09-20T14:56:01Z

sorry for keep this hanging , i will get it done by today or tomorrow

dev13-suthar · 2024-09-22T05:36:04Z

100xJobs.-.Google.Chrome.2024-09-22.10-56-59.mp4

dev13-suthar · 2024-09-22T05:43:37Z

We can raise issue for better login and logout button and signin/signup form

VineeTagarwaL-code · 2024-09-22T09:46:10Z

comment out the login flow, only ahve for admin a lot of pr has this and they are more better on this tbh

dev13-suthar · 2024-09-22T11:56:32Z

100xJobs.-.Google.Chrome.2024-09-22.16-53-40.mp4

ready to merge i think

dev13-suthar · 2024-09-26T15:31:08Z

@VineeTagarwaL-code

VineeTagarwaL-code · 2024-10-02T19:24:37Z

fix conflicts, need to merge

dev13-suthar · 2024-10-04T18:17:24Z

fixing

VineeTagarwaL-code · 2024-10-04T18:27:16Z

build fails, fix please

dev13-suthar · 2024-10-04T18:58:40Z

fixed

dev13-suthar · 2024-10-04T19:12:54Z

it should work now

aakash2330 · 2024-10-06T16:48:09Z

src/actions/job.action.ts

+>(async (data) => {
+  const result = deleteJobByIdSchema.parse(data);
+  const { id } = result;
+  const deletedJob = await prisma.job.delete({


lets create a new field in job (deleted) which will flag it true or false instead of removing it from db

aakash2330 · 2024-10-06T16:49:03Z

src/actions/job.action.ts

+  ApproveJobSchemaType,
+  ServerActionReturnType<ApprovedJobID>
+>(async (session, data) => {
+  if (session.user.role === 'USER') {


should be an admin check here in case we add users with other roles

aakash2330 · 2024-10-06T16:50:04Z

src/actions/job.action.ts

+  if (session.user.role === 'USER') {
+    throw new Error('Unauth Access');
+  }
+  const result = ApproveJobSchema.parse(data);


use safeParse instead of parse

but other actions are using parse only, if i use safeparse there will be an other check for if(data.success)

yes , it's better to safe parse

aakash2330 · 2024-10-06T16:50:16Z

src/actions/job.action.ts

+  JobQuerySchemaType,
+  ServerActionReturnType<getAllJobsAdditonalType>
+>(async (session, data) => {
+  if (session.user.role === 'USER') {


refer the comment above , try makin a wrapper on top of the with session function e.g. withAdminServerAction , something like that so you wont have to repeat this step

aakash2330 · 2024-10-06T16:52:05Z

src/actions/job.action.ts

+});
+
+export const getAllJobsForAdmin = withSession<
+  //not the ideal action we should make getAllJobs() better so we can have option to display verified and unverified jobs by Inputs


please do , add that in the getAll routes itself

what im thinking is, if user role is admin return all job whether they are verified or unverified and if role is user return only verified job/ should i go with this?

aakash2330 · 2024-10-06T16:57:18Z

src/components/JobManagementHeader.tsx

+        <div>
+          <Button
+            onClick={() => {
+              router.push('/create');


use link tag instead

aakash2330 · 2024-10-06T17:00:44Z

src/components/JobManagementTable.tsx

+
+const JobManagementTable = ({ jobs, searchParams, initialJobs }: props) => {
+  const { toast } = useToast();
+  const [DispJobs, setDispJobs] = useState<JobType[]>(initialJobs);


instead of just the initial jobs , can you make all of them server rendered ?

it was server rendered before, but because of server renders when something gets change like if job approves then the datatable was not syncing with the DB unless u hard refresh

you'll have to revalidate the route , and then it'll work

aakash2330 · 2024-10-06T17:02:24Z

src/components/JobManagementTable.tsx

+    }
+  };
+
+  const refreshJobs = async () => {


why do we need this function ? is it just to fetch the latest changes ?.

it calls everytime searchparams changes to fetch and put latest job with local state variable

you don't need this if youre rendering table on server side

let this merge, i will update it later

aakash2330 · 2024-10-06T17:03:41Z

src/components/JobManagementTable.tsx

+  const totalPages =
+    Math.ceil((jobs.additional?.totalJobs || 0) / JOBS_PER_PAGE) ||
+    DEFAULT_PAGE;
+  const currentPage = parseInt(searchParams.page?.toString()) || DEFAULT_PAGE;


why do we need the toString() here , if you parse the search params correctly before passing it to this table component , we wont need it

aakash2330 · 2024-10-06T17:07:04Z

src/components/JobManagementTable.tsx

+                <PaginationPreviousButton
+                  searchParams={searchParams}
+                  currentPage={currentPage}
+                  baseUrl={APP_PATHS.JOBS}


can you also remove the need for this to be passed , its not required

Pagination not required?

no , we don't need the baseUrl to be paaed

dev13-suthar · 2024-10-08T06:13:06Z

@VineeTagarwaL-code done ready to merge new feat

dev13-suthar · 2024-10-11T06:43:26Z

merge these before major updates that will be coming like user onboarding. @VineeTagarwaL-code

dev13-suthar · 2024-10-14T03:31:39Z

@VineeTagarwaL-code solved all reviews bugs and now Table is also Server rendered.

VineeTagarwaL-code · 2024-10-20T08:37:14Z

fix conflicts need to merge

dev13-suthar · 2024-10-21T05:46:19Z

@VineeTagarwaL-code done

VineeTagarwaL-code · 2024-10-21T05:58:05Z

give vid ref of current status of the pr

dev13-suthar · 2024-10-21T06:17:32Z

finalPreview.mp4

VineeTagarwaL-code · 2024-10-21T18:58:34Z

A new issue will open to improve the ui of this page and possible add more functionality but great work

Make sure you post your pr getting merged on x

Dev added 6 commits September 3, 2024 23:10

inited job management feature

df7e8bc

delete feat with TypeSafe

520d640

Merge branch 'main' into feat/job-management

dffda9e

addded pagination

ad8a760

Merge branch 'main' into feat/job-management

fec8009

deactivated delete functionality

e8d2c2b

Merge branch 'main' into feat/job-management

66675ee

Dev added 3 commits September 17, 2024 09:45

merged

8e15c9f

Resolved conflicts and Updated code

d11e7c7

Merge branch 'main' into feat/job-management

0c9de7b

Merge branch 'main' into feat/job-management

48108c5

Dev added 2 commits September 23, 2024 11:19

new feat job approve

89f36c2

resolved conflicts

45da1b6

Merge branch 'main' into feat/job-management

d0da9b0

Dev added 3 commits October 5, 2024 00:03

fixed conflicts and build error

af10bf2

Merge branch 'main' into feat/job-management

f3175d6

fixed self branch conflict

763bf3a

made isVerfied field optional jobType

b68e700

fixed some ui bugs

cb57a78

VineeTagarwaL-code mentioned this pull request Oct 6, 2024

🐛 Bug Report: overflow issue #464

Closed

2 tasks

aakash2330 reviewed Oct 6, 2024

View reviewed changes

Dev added 2 commits October 7, 2024 09:34

merged main

52e39bf

fixed conflicts_and_bugs

60cf430

made Datatable SSR

972a638

fixed conflicts and build err

5292725

VineeTagarwaL-code merged commit b195ae9 into code100x:main Oct 21, 2024
1 check passed

FEAT/Added Job Management Page #300

FEAT/Added Job Management Page #300

Conversation

dev13-suthar commented Sep 5, 2024

dev13-suthar commented Sep 10, 2024

VineeTagarwaL-code commented Sep 16, 2024

dev13-suthar commented Sep 17, 2024

dev13-suthar commented Sep 17, 2024

dev13-suthar commented Sep 17, 2024

VineeTagarwaL-code commented Sep 17, 2024

dev13-suthar commented Sep 18, 2024

VineeTagarwaL-code commented Sep 18, 2024

dev13-suthar commented Sep 18, 2024

VineeTagarwaL-code commented Sep 18, 2024

dev13-suthar commented Sep 19, 2024 • edited Loading

VineeTagarwaL-code commented Sep 19, 2024

dev13-suthar commented Sep 20, 2024

dev13-suthar commented Sep 22, 2024

dev13-suthar commented Sep 22, 2024

VineeTagarwaL-code commented Sep 22, 2024

dev13-suthar commented Sep 22, 2024

dev13-suthar commented Sep 26, 2024

VineeTagarwaL-code commented Oct 2, 2024

dev13-suthar commented Oct 4, 2024

VineeTagarwaL-code commented Oct 4, 2024

dev13-suthar commented Oct 4, 2024

dev13-suthar commented Oct 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dev13-suthar commented Oct 8, 2024

dev13-suthar commented Oct 11, 2024

dev13-suthar commented Oct 14, 2024

VineeTagarwaL-code commented Oct 20, 2024

dev13-suthar commented Oct 21, 2024

VineeTagarwaL-code commented Oct 21, 2024

dev13-suthar commented Oct 21, 2024

VineeTagarwaL-code commented Oct 21, 2024

dev13-suthar commented Sep 19, 2024 •

edited

Loading