This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
Add task to destroy guest users after one week #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #256.
This destroys users that were created more than one week ago. Is there a way to determine if a user has been inactive, so that we are not destroying active guest users? Is there any reason an active user would remain a guest?
I believe this will not destroy units associated with guest users. Is that the correct behavior?
I can write a spec for the task if necessary.
This does not add any method of scheduling the task. The issue mentioned sidekiq, but that seems like overkill just to run a single job per week. The best option probably depends mostly on how this is being hosted.