Skip Suite on Filter for Jest only

codeforequity-at · May 19, 2019 · 12a00cf · 12a00cf
1 parent 16b388d
commit 12a00cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/BotiumBindings.js b/src/BotiumBindings.js
@@ -96,10 +96,9 @@ module.exports = class BotiumBindings {
       this.compiler.scriptingEvents.fail = failCb
     }
 
-    let testCount = 0
     this.compiler.convos.forEach((convo) => {
       debug(`adding test case ${convo.header.toString()}`)
-      const included = testcaseCb(convo, (testcaseDone) => {
+      testcaseCb(convo, (testcaseDone) => {
         if (this.container) {
           debug(`running testcase${convo.header.toString()}`)
 
@@ -116,13 +115,7 @@ module.exports = class BotiumBindings {
           testcaseDone(new Error('Botium Initialization failed. Please see error messages above (enable debug logging).'))
         }
       })
-      if (included) {
-        testCount++
-      }
     })
-    if (testCount == 0) {
-      it.skip('skip empty test suite', () => {})
-    }
   }
 
   UserSaysText (...args) {

diff --git a/src/helpers/jest.js b/src/helpers/jest.js
@@ -1,18 +1,23 @@
-/* global describe test beforeAll beforeEach afterAll afterEach */
+/* global describe test it beforeAll beforeEach afterAll afterEach */
 
 const BotiumBindings = require('../BotiumBindings')
 
 const setupJestTestCases = ({ testcaseSelector, bb } = {}) => {
   bb = bb || new BotiumBindings()
 
+  let testCount = 0
   bb.setupTestSuite(
     (testcase, testcaseFunction) => {
       if (testcaseSelector && !testcaseSelector(testcase)) return false
 
+      testCount++
       test(testcase.header.name, testcaseFunction)
       return true
     }
   )
+  if (testCount === 0) {
+    it.skip('skip empty test suite', () => {})
+  }
 }
 
 const setupJestTestSuite = ({ name, testcaseSelector, bb } = {}) => {