-
Notifications
You must be signed in to change notification settings - Fork 103
Enabled multi-selection support for several commands #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
👋 A new build is available for this PR based on 38ff4af. |
Signed-off-by: Seb Julliand <[email protected]>
Edit: on second thought, prompted custom actions should be prompted once and executed many times instead of prompting each item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally the code looks ok but I left some comments.
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Thanks @worksofliam ; see my comment and give it a go 😀 |
@sebjulliand Generally it's looking good. I want to also add at least one test case for each file system in |
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
@worksofliam tests are in, one for each scheme as requested. |
Changes
As discussed here: https://github.com/orgs/codefori/discussions/2612
This PR enables multi-selection support for the following commands:
Run multiple custom actions
Some noticeable changes were done to allow running custom actions on multiple items.
All the selected items must share the same nature (i.e. URI scheme) (otherwise a warning is shown)
If the command must be prompted
, it will do so for each item:The whole execution can now be cancelled. It will stop the process after the current item is done being processed

The output webview had been enhanced to display multiple outputs. The left side displays items' path and the right side shows the selected item output. The icon in front of the item shows the execution result (ok, failed or not run).

Running an action on a single item will only show the single output (no need for navigating through multiple results)
Search in members / Search/find in streamfiles
Finding or searching can be cancelled. The search will stop after the current path is done being processed.
Once a path has been processed, the results are added to the Search Results view, which means the view gets populated dynamically while the search is running.
How to test this PR
ctrl+click
orshift+click
to select multiple items in the Object browser or IFS browserChecklist