More ineligibility categories #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wittejm
changed the title
wittejm
force-pushed
the
jw/more-ineligibility-categories
branch
from
ccf2948
to
cdbcbe0
Compare
wittejm
force-pushed
the
jw/more-ineligibility-categories
branch
from
cdbcbe0
to
074bcd7
Compare
|
Ready for review @KentShikama . I was stuck for a while on a bug from It's not clear to me what this sort is even for (the ordered numbers in the key function) since the grouped charges don't get rendered in the same order. |
KentShikama
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this covers part of #1656
This uses a demo record to test, which I expanded with two cases that provide the new ineligibility categories.
