Remove the question from Multnomah violations and make them all Needs More Analysis #1716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Michael spotted a record that the analyzer failed on because it had too many ambiguities (4096, where the limit is 128). He guessed that our new logic on Multnomah violations was causing the error, and when I removed the question from these charges it fixed the record that was breaking.
Michael said this new approach is acceptable: the user can update these charges to a Violation type if they are not traffic-related and thus eligible.
It kind of sucks because the descriptions in the record include "Alcohol on Public Property" and "Disorderly Conduct in the Second Degree", and we could add checks for all these sorts of strings....
For now, I'm making the fix that will un-break long records.