Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the question from Multnomah violations and make them all Needs More Analysis #1716

Merged

Conversation

wittejm
Copy link
Contributor

@wittejm wittejm commented Nov 28, 2023

Michael spotted a record that the analyzer failed on because it had too many ambiguities (4096, where the limit is 128). He guessed that our new logic on Multnomah violations was causing the error, and when I removed the question from these charges it fixed the record that was breaking.

Michael said this new approach is acceptable: the user can update these charges to a Violation type if they are not traffic-related and thus eligible.

It kind of sucks because the descriptions in the record include "Alcohol on Public Property" and "Disorderly Conduct in the Second Degree", and we could add checks for all these sorts of strings....

For now, I'm making the fix that will un-break long records.

@wittejm wittejm requested a review from KentShikama November 28, 2023 19:52
@wittejm
Copy link
Contributor Author

wittejm commented Nov 28, 2023

I'm doing to add a check on a list of strings that are clearly not traffic violations in a separate PR.

@wittejm wittejm merged commit 9342227 into codeforpdx:master Nov 29, 2023
@wittejm wittejm deleted the remove-question-from-multnomah-violations branch July 26, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants