Remove autofill 1 #1734
Merged
Remove autofill 1 #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating form_filling to remove county court autofill
wittejm
approved these changes
Jul 26, 2024
| @@ -396,7 +396,8 @@ def extra_mappings(self): | |||
| # Is the OSP Form | |||
| osp_fields: Dict[str, object] = {} | |||
| for i in range(10): | |||
| osp_fields[f"(Court {i+1})"] = f"Circuit Court for {s.counties_with_cases_to_expunge[i]} County" if i<len(s.counties_with_cases_to_expunge) else "" | |||
| #osp_fields[f"(Court {i+1})"] = f"Circuit Court for {s.counties_with_cases_to_expunge[i]} County" if i<len(s.counties_with_cases_to_expunge) else "" | |||
| osp_fields[f"(Court {i+1})"] = "" | |||
| if s.has_eligible_convictions: | |||
| osp_fields["(Include a Conviction Yes)"] = True | |||
There was a problem hiding this comment.
This part should also be removed: we don't want to check the box anymore, until the whole thing is fixed.
| @@ -39,6 +39,7 @@ def handle_person(output, client, row): | |||
| aliases = [alias] | |||
| response = client.post("http://localhost:5000/api/search", json={"aliases": aliases}) | |||
| record = json.loads(response.text)["record"] | |||
| print(record) | |||
| @@ -705,4 +706,5 @@ def counties_with_cases_to_expunge(all_case_results: List[CaseResults]): | |||
| if case_result.case.summary.balance_due_in_cents != 0: | |||
| counties_with_balances.append(case_result.case.summary.location) | |||
| counties_with_expungements = [county for county in counties_with_eligible_charge if county not in counties_with_balances] | |||
| return counties_with_expungements | |||
| return [] | |||
There was a problem hiding this comment.
Not a big deal since the result of this function isn't used anymore, but I think this change in particular is confusing since it breaks the functionality. I would either leave it alone or comment out the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed OSP court autofill and updated tests to reflect changes. This was erroneously listed as a fix in the description of pull request #1733.