Add Rustdesk module #266
Add Rustdesk module #266
Conversation
|
@matifali can you release the pending asset (150$)? |
This is released automatically once the PR is merged and closed |
No comment! But why I'm being delayed as this PR resolve the issue? |
There is no intentional delay, as Algora releases the bounty once the PR is approved, and merged. This is outlined in the Coder Bounty Issue #213 |
| # A built-in icon like "/icon/code.svg" or a full URL of icon | ||
| icon_url = "https://upload.wikimedia.org/wikipedia/commons/9/96/Rustdesk.svg" | ||
| } |
There was a problem hiding this comment.
why do we have this if you have the rustdesk svg in the icons dir?
| ``` | ||
| Also add this within resource "docker_container" "workspace": | ||
|
|
||
| ```hcl |
There was a problem hiding this comment.
These should be tf instead of hcl
| RUSTDESK_DEB="rustdesk-$RUSTDESK_VERSION-x86_64.deb" | ||
|
|
||
| echo "Downloading RustDesk $RUSTDESK_VERSION..." | ||
| wget "https://github.com/rustdesk/rustdesk/releases/download/$RUSTDESK_VERSION/$RUSTDESK_DEB" |
There was a problem hiding this comment.
RustDesk offers options for various different architectures. Can you set this up to work with more than just debian based systems?
| # Start perform other necessary actions perform other necessary actions | ||
| echo "Starting Rustdesk..." | ||
| # Start virtual display | ||
| Xvfb :99 -screen 0 1024x768x16 & |
There was a problem hiding this comment.
I feel like the resolution should be a variable, so that it can be changed by the user if they don't want the display to be stuck in this resolution.
RustDesk.toml
Outdated
| @@ -0,0 +1,2 @@ | |||
| [security] | |||
There was a problem hiding this comment.
is this necessary?
You could also make the password something that is set by the user or default in a variable, so that the user can control this and they wouldn't have to go digging for the password or set it themselves after install
rustdesk-1.1.9.deb
Outdated
There was a problem hiding this comment.
These deb's should not be included in the PR and are likely left over from testing the module. You might also want to ensure that your cleanup is properly catching these since generally they should have been removed automatically
|
@BenraouaneSoufiane Just checking if there is any update on this? |
Fixed, thank you! |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new RustDesk module that enables remote desktop access within Coder workspaces. The module automates the installation of RustDesk, sets up a virtual display using Xvfb, and provides connection credentials for remote access.
Key changes:
- Adds a complete RustDesk module with cross-platform package manager support
- Implements automatic password generation and virtual display configuration
- Provides Terraform integration with configurable parameters
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
registry/BenraouaneSoufiane/modules/rustdesk/run.sh |
Main installation and setup script with package manager detection and RustDesk configuration |
registry/BenraouaneSoufiane/modules/rustdesk/main.tf |
Terraform module definition with variables and Coder resource configuration |
registry/BenraouaneSoufiane/modules/rustdesk/README.md |
Module documentation with usage instructions and configuration examples |
registry/BenraouaneSoufiane/README.md |
Author profile information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@DevelopmentCats thank you for your suggestions, I've committed the suggested fixes |
Tell users how to use/customize the module like rustdesk version, virtual screen dimentions & the password
|
Can you run |
Closes #79
Description
This PR add new module, install minimal desktop environment (xfce), virtual display, ,rustdesk package from deb file, init new screen, export DISPLAY environment variable with last created virtual screen, start new xfce session & execute the rustdesk cli, generate new password, change the default password, then log the ID & password to be used within rustdesk client to connect to the host
Type of Change
Module Information
Overview/test video: live demo that launch rustdesk with GUI in a docker container https://youtu.be/_rR-l7nARN4
Screenshots:
Path:
registry/BenraouaneSoufiane/modules/rustdeskNew version:
v1.0.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Related Issues
/claim #79 (remain asset 150$)