-
Notifications
You must be signed in to change notification settings - Fork 46
feat(zed): settings input and MCP servers example #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional settings input to write/merge ~/.config/zed/settings.json - Document MCP servers example and settings.json path Co-authored-by: Atif Ali <[email protected]>
Requesting review from @matifali. PR adds |
matifali
commented
Aug 11, 2025
…use jsonencode)\n- update description per suggestion\n- README: link to Zed settings docs and jsonencode example
This comment was marked as resolved.
This comment was marked as resolved.
matifali
commented
Aug 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
DevelopmentCats
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
settings
input to the Zed module and updates the README with an example for configuring MCP servers.Changes:
settings
variable to modules/zed/main.tfcoder_script
to write/merge~/.config/zed/settings.json
(respects$XDG_CONFIG_HOME
and merges with existing settings ifjq
is available)settings
example configuring MCP context servers and clarify default settings pathTest plan:
bun test --filter zed
fails in CI without Terraform; this change only adds inputs and a startup script. No behavior change to existing outputs.Co-authored-by: Atif Ali [email protected]