Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black formatting + finished bidded-task api #168

Conversation

SodaVolcano
Copy link
Collaborator

@SodaVolcano SodaVolcano commented Jul 24, 2024

Added route that returns a list of TASKS but with the bidded price added, can easily use with TaskCard

I'm surprised that black was never ran on the backend code??

<TaskCard
              key={index}
              title={task.title}
              category={task.category}
              date={task.date}
              location={task.location}
              duration={task.duration}
              estimatePrice={task.estimatePrice}
              myOfferPrice={task.offered_price}   // PUT NEW FIELD HERE!!
              onClick={() => router.push(`/bidder/market/${task.task_id}`)}
            />

http://localhost:8000/api/app/users/10/bidded-tasks

Related issue

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
penni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 3:01am

@SodaVolcano SodaVolcano requested review from yunho7687 and ErikaKK July 24, 2024 16:21
@SodaVolcano
Copy link
Collaborator Author

got a bunch of complaints from flake8 about lines being too long probably because I ran black. I'm not changing :)

Copy link
Contributor

@ErikaKK ErikaKK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls add an API to get all bids for one task based on the task_id (could be empty list)

Copy link
Contributor

@ErikaKK ErikaKK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check if there is conflict with your idea @yunho7687. I'm not that good with backend

@SodaVolcano
Copy link
Collaborator Author

Pls check if there is conflict with your idea @yunho7687. I'm not that good with backend

We can just merge one of the branches and let Github/Git highlight the merge conflict, manually checking takes too much time

@yunho7687 yunho7687 closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API to get tasks that a user have bidded for (BiddedTask)
3 participants