Issue 14 create a generic button component #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeiKasahara
added
frontend
yunho7687
reviewed
Jun 27, 2024
client/tailwind.config.ts
Outdated
| @@ -23,6 +23,7 @@ const config = { | |||
| sans: ["var(--font-sans)", ...fontFamily.sans], | |||
| }, | |||
| colors: { | |||
| customPrimary: "hsl(var(--customPrimary))", | |||
There was a problem hiding this comment.
you could use penni-main:"#0051CA" here to make it more semantic.
good job tho
There was a problem hiding this comment.
I found variables like "--customPrimary" should be included in global.css, I added this var in global.css like the 16th line: --customPrimary: 225, 100%, 40%; /*#0051CA Penni Blue*/ 👀
There was a problem hiding this comment.
add "penni-main“:"#0051CA" here and use it like className="bg-penni-main"
we use tailwind css so, from my perspective, we should configure the theme color in tailwind.config.ts
There was a problem hiding this comment.
I'll modify it
yunho7687
reviewed
Jun 27, 2024
yunho7687
approved these changes
Jun 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Created a generic button component with the requirement of penni design
Added CSS attributes
Change Form
Related issue