Production #181
Merged
Production #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodeWithTheDoctor
requested changes
Oct 17, 2024
client/src/lib/api.ts
Outdated
| @@ -4,7 +4,7 @@ const api = axios.create({ baseURL: process.env.NEXT_PUBLIC_BACKEND_URL }); | |||
|
|
|||
| export default api; | |||
|
|
|||
| const LocalBaseURL = "http://localhost:8000/api"; // local use | |||
| const LocalBaseURL = "http://170.64.220.156:8000/api"; // local use | |||
There was a problem hiding this comment.
Hey everything looks great! Also, could we put the IP in the .env file, and reference it using the environment variable? Just to adhere to standard practice and make it easier for future devs to change. <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]