segfault: gethostbyname(), double free with invalid destination addresses #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling into the resolver causes a segfault: ~~~ LD_PRELOAD=./libglb.so GLB_OPTIONS="--random 1234 x" ls Segmentation fault (core dumped) ~~~ For libglb, bypass the resolver and parse the IPv4 address.
If parsing the destination list from the environment fails, the pointer to the configuration may be freed twice: by glb_parse_dst_list() and glb_env_parse(): ~~~ $ LD_PRELOAD=./src/.libs/libglb.so GLB_OPTIONS="--random 1234 x" ls LIBGLB: ERROR: glb_dst.c:86: Invalid argument Invalid destination spec: x *** Error in `nc': double free or corruption (!prev): 0x0091c008 *** Aborted (core dumped) ~~~ Check the return value from env_parse_options()/glb_parse_dst_list() was not NULL before attempting to free().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.