Skip to content

Commit

Permalink
client tests: remove an old TODO item
Browse files Browse the repository at this point in the history
This was introduced in 0df648c, but we've moved away from Travis CI
a long time ago.
  • Loading branch information
codesenberg committed Apr 29, 2023
1 parent 2672948 commit b69aef3
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions clients_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ package main

import (
"bytes"
"context"
"crypto/tls"
"net/http"
"net/http/httptest"
"sync/atomic"
"testing"
"time"
)

func TestShouldReturnNilIfNoHeadersWhereSet(t *testing.T) {
Expand Down Expand Up @@ -85,8 +85,6 @@ func TestHTTP2Client(t *testing.T) {
errChan <- err
}()

// TODO(codesenberg): this should be fixed later
time.Sleep(100 * time.Millisecond)
bytesRead, bytesWritten := int64(0), int64(0)
c := newHTTPClient(&clientOpts{
HTTP2: true,
Expand All @@ -108,6 +106,10 @@ func TestHTTP2Client(t *testing.T) {
t.Error(err)
return
}
ctx := context.Background()
if err := s.Shutdown(ctx); err != nil {
t.Error(err)
}
if code != http.StatusOK {
t.Errorf("invalid response code: %v", code)
}
Expand Down

0 comments on commit b69aef3

Please sign in to comment.