Skip to content

Complete reactjs-fundamentals class #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: kuma
Choose a base branch
from

Conversation

Parkhyunseo
Copy link
Contributor

1강-6강 시청 완료

@Parkhyunseo Parkhyunseo added the enhancement New feature or request label Dec 4, 2019
@Parkhyunseo Parkhyunseo self-assigned this Dec 4, 2019
Copy link

@Tetramad Tetramad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 식으로 코드 리뷰 하면 되나요?

import { Link } from "react-router-dom";
import "./Movie.css";

function Movie({id, year, title, summary, poster, genres }) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint 중괄호({}) 안 띄어쓰기를 수정해야 할 것 같습니다.

Comment on lines +1 to +5
import React from 'react';
import ReactDOM from 'react-dom';
import App from './App';

ReactDOM.render(<App />, document.getElementById('root'));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format 문자열을 사용할 때 작은 따옴표를 쓸 것인지 큰 따옴표를 쓸 것인지 통일해주세요ㅎㅎ

@@ -0,0 +1,14 @@

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것도 리뷰해야 되나요?

import React from "react";

function About(){
return<span>About this page: I built it because I love movies.</span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세미콜론을 적어주세요.

Comment on lines +1 to +4
import React from 'react';
import axios from 'axios';
import Movie from "../components/Movie";
import "./Home.css";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문자열 통일

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants