Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use type imports for block events #2491

Merged
merged 3 commits into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- `Fix` — Layout did not shrink when a large document cleared in Chrome
- `Fix` — Multiple Tooltip elements creation fixed
- `Fix` — When the focusing Block is out of the viewport, the page will be scrolled.
- `Fix` - Compiler error "This import is never used as a value and must use 'import type'..." fixed
- `Fix` — `blocks.render()` won't lead the `onChange` call in Safari
- `Fix` — Editor wrapper element growing on the Inline Toolbar close
- `Fix` — Fix errors thrown by clicks on a document when the editor is being initialized
Expand Down
2 changes: 1 addition & 1 deletion types/events/block/Base.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BlockAPI } from '../../api';
import type { BlockAPI } from '../../api';

/**
* Details of CustomEvent fired on block mutation
Expand Down
2 changes: 1 addition & 1 deletion types/events/block/BlockAdded.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BlockMutationEventDetail } from './Base';
import type { BlockMutationEventDetail } from './Base';

/**
* Type name of CustomEvent related to block added event
Expand Down
2 changes: 1 addition & 1 deletion types/events/block/BlockChanged.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BlockMutationEventDetail } from './Base';
import type { BlockMutationEventDetail } from './Base';

/**
* Type name of CustomEvent related to block changed event
Expand Down
2 changes: 1 addition & 1 deletion types/events/block/BlockMoved.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BlockMutationEventDetail } from './Base';
import type { BlockMutationEventDetail } from './Base';

/**
* Type name of CustomEvent related to block moved event
Expand Down
2 changes: 1 addition & 1 deletion types/events/block/BlockRemoved.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BlockMutationEventDetail } from './Base';
import type { BlockMutationEventDetail } from './Base';

/**
* Type name of CustomEvent related to block removed event
Expand Down
8 changes: 4 additions & 4 deletions types/events/block/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { BlockAddedEvent, BlockAddedMutationType } from './BlockAdded';
import { BlockChangedEvent, BlockChangedMutationType } from './BlockChanged';
import { BlockMovedEvent, BlockMovedMutationType } from './BlockMoved';
import { BlockRemovedEvent, BlockRemovedMutationType } from './BlockRemoved';
import { type BlockAddedEvent, BlockAddedMutationType } from './BlockAdded';
import { type BlockChangedEvent, BlockChangedMutationType } from './BlockChanged';
import { type BlockMovedEvent, BlockMovedMutationType } from './BlockMoved';
import { type BlockRemovedEvent, BlockRemovedMutationType } from './BlockRemoved';

/**
* Map for Custom Events related to block mutation types
Expand Down
Loading