fix: errors caused by events fired while editor is not initialized yet #2532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users reported problems with errors that happen by document click at the moment when Editor is not fully initialised:
Cause
Our current TS setup is not strict. So we missed some cases, when module
nodes
field can containundefined
values (when UI is not fully constructed)Se we don't have check for
undefined
in many places, includingdocumentClicked
ordocument.onMouseOver
event handlers.Solution
undefined
type to some module nodesundefined
case in event handlersreequestIdleCallback
to bind them only when UI is ready.