Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed css stoke overwrite issue #2826

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fixed css stoke overwrite issue #2826

wants to merge 1 commit into from

Conversation

Dxuian
Copy link

@Dxuian Dxuian commented Sep 9, 2024

Resolves #2294
prevents overwriting of attributes from user inputted svgs

neSpecc
neSpecc reviewed Sep 13, 2024
View reviewed changes
.vscode/settings.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irrelevant changes

.gitignore
@@ -18,3 +18,4 @@ dist/
coverage/
.nyc_output/
.vscode/launch.json
.vscode/settings.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irrelevant change

src/styles/ui.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update a changelog, please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
before:
image

after:
image

neSpecc
neSpecc requested changes Jan 11, 2025
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Irrelevant changes should be removed
  • Changelog should be updated
  • Test should be added if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc requested changes

@gohabereg gohabereg Awaiting requested review from gohabereg gohabereg is a code owner

@TatianaFomina TatianaFomina Awaiting requested review from TatianaFomina TatianaFomina is a code owner

@ilyamore88 ilyamore88 Awaiting requested review from ilyamore88 ilyamore88 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
almost done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS overriding the style of block tool SVG component
2 participants
@Dxuian @neSpecc