Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Backspaces do not work when the code block contains initial data. #2836

Open
wants to merge 8 commits into
base: next
Choose a base branch
from
Open

fix: Backspaces do not work when the code block contains initial data. #2836

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a404db
fix: Do not search Leaf when argument input is Native input
yosipy Oct 4, 2024
8cec5c9
refactor: determine whether it is native input in getDeepestNode
yosipy Oct 5, 2024
60692ae
Merge branch 'next' into patch-1
yosipy Oct 9, 2024
2b624d2
Merge branch 'next' into patch-1
yosipy Oct 10, 2024
316514e
Update CHANGELOG.md
yosipy Oct 10, 2024
971be28
Revert "Update CHANGELOG.md"
yosipy Oct 10, 2024
3282b43
Update CHANGELOG.md
yosipy Oct 10, 2024
62d3942
Merge branch 'next' into patch-1
yosipy Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/utils/caret.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export function checkContenteditableSliceForEmptiness(contenteditable: HTMLEleme
* @param input - input where caret should be checked
*/
export function isCaretAtStartOfInput(input: HTMLElement): boolean {
const firstNode = $.getDeepestNode(input);
const firstNode = $.isNativeInput(input) ? input : $.getDeepestNode(input);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to update getDeepestNode instead. It already contains a logic that will return a passed node, but seems like node[child] statement does not cover this case

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing it out.
I think you are right too.

Fixed in 8cec5c9.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neSpecc
Please re-review.


if (firstNode === null || $.isEmpty(input)) {
return true;
Expand Down