Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fix for memory leak issue #2893

Merged
merged 11 commits into from
Jan 8, 2025
Merged

Added fix for memory leak issue #2893

merged 11 commits into from
Jan 8, 2025

Conversation

obafemitayor
Copy link
Contributor

@obafemitayor obafemitayor commented Dec 21, 2024 •
edited
Loading

Related Issue

What Changed

  • Fixed memory leak issue in the Shortcuts class

Testing Strategy

@obafemitayor obafemitayor mentioned this pull request Dec 21, 2024
Open
neSpecc
neSpecc reviewed Dec 21, 2024
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the docs/CHANGELOG.md

@obafemitayor
Copy link
Contributor Author

Please, update the docs/CHANGELOG.md

@neSpecc I have updated the docs/CHANGELOG.md file

@obafemitayor
Copy link
Contributor Author

Hello @neSpecc , have you had the chance to look at this again?

@neSpecc neSpecc merged commit d15a8c2 into codex-team:next Jan 8, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Open
@neSpecc
Copy link
Member

neSpecc commented Jan 8, 2025

Thanks, @obafemitayor . If you want to continue contributing, let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

@gohabereg gohabereg Awaiting requested review from gohabereg gohabereg is a code owner

@TatianaFomina TatianaFomina Awaiting requested review from TatianaFomina TatianaFomina is a code owner

@ilyamore88 ilyamore88 Awaiting requested review from ilyamore88 ilyamore88 is a code owner

Assignees
No one assigned
Labels
almost done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obafemitayor @neSpecc @omotayor-testlio