Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "+X other results" count in timeline hover #898

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

sgalla
Copy link
Collaborator

@sgalla sgalla commented Mar 18, 2024

Fix the +X other results counter in the timeline visual to be accurate in the case of multi valued date attributes. This number represents the number of additional metacard results and does not indicate the number of total date values.

timelineCounterFix.mp4

Testing:

  1. Upload more than 5 files
  2. Populate at least one value for datetime.start on each metacard
  3. Open the timeline visual, select datetime.start, and verify the tooltip shows the correct number of "other results". For example, if you have 8 total metacards with non-empty datetime.start, you should see +3 other results

@sgalla
Copy link
Collaborator Author

sgalla commented Mar 18, 2024

build now

Copy link

An updated dist branch has been created and pushed to origin.
You can use:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-898",
in your package.json to use this version in your project.

Remember to use "yarn install --force" if you want to pick up changes each time you make a change to this branch by committing.

github-actions bot pushed a commit that referenced this pull request Mar 18, 2024
@sgalla
Copy link
Collaborator Author

sgalla commented Mar 18, 2024

build now

@cxddfuibot
Copy link
Collaborator

Internal build has been started, your results will be available at build completion.

@cxddfuibot
Copy link
Collaborator

Build ABORTED See the job results in legacy Jenkins UI or in Blue Ocean UI.

@sgalla
Copy link
Collaborator Author

sgalla commented Mar 19, 2024

build now

@cxddfuibot
Copy link
Collaborator

Internal build has been started, your results will be available at build completion.

@cxddfuibot
Copy link
Collaborator

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jlcsmith jlcsmith merged commit f2c2ef9 into master Mar 28, 2024
3 checks passed
Copy link

You can no longer use:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-898",
in your package.json to use this version in your project, as it has been deleted now that the pull request is closed.

Instead, if the pr was merged you can now access these changes by using:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-snapshot",

Remember to use "yarn install --force" if you want to pick up changes to this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants