Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.29.9.x] Adds geotools support for shp files #6886

Merged
merged 2 commits into from
Apr 5, 2025

Conversation

jlcsmith
Copy link
Member

@jlcsmith jlcsmith commented Apr 4, 2025

What does this PR do?

In cases where geotools was asked to process shapefiles, the underlying data factory was not available leading to a a processing failure. This PR adds the necessary factory to the GeotoolsPluginLoader

Who is reviewing it?

@glenhein
@derekwilhelm
@pklinef

Select relevant component teams:

@codice/core-apis

Ask 2 committers to review/merge the PR and tag them here.

@glenhein
@derekwilhelm
@pklinef

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@jlcsmith
Copy link
Member Author

jlcsmith commented Apr 4, 2025

build now

@cxddfbot
Copy link

cxddfbot commented Apr 4, 2025

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Apr 4, 2025

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jlcsmith
Copy link
Member Author

jlcsmith commented Apr 4, 2025

Looking into CSW test failures
[INFO] Tests run: 142, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.571 s - in org.codice.ddf.spatial.ogc.csw.catalog.common.source.CswFilterDelegateTest [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] CswCqlFilterTest.testBeyondPropertyOwsBoundingBoxPoint:1457 Expected: is "BEYOND(\"ows:BoundingBox\", POINT (30 30), 123.456, METERS)" but: was "BEYOND(\"ows:BoundingBox\", SRID=4326;POINT (30 30), 123.456, METERS)"

@jlcsmith jlcsmith changed the title [2.29.9.x] Adds geotools support for csv and shp files [2.29.9.x] Adds geotools support for shp files Apr 5, 2025
@jlcsmith
Copy link
Member Author

jlcsmith commented Apr 5, 2025

build now

@cxddfbot
Copy link

cxddfbot commented Apr 5, 2025

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Apr 5, 2025

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jlcsmith jlcsmith requested a review from alexabird April 5, 2025 16:50
@jlcsmith jlcsmith merged commit 0ea4f43 into 2.29.9.x Apr 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants