Add rbs signatures #1161
Draft
Add rbs signatures #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially auto-generated, partially manually set
Taeir
force-pushed
the
add-rbs-signatures
branch
from
d7fdb34 to
46c4eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds so-called RBS type signatures for our codebase.
sig/rbs-railsare auto-generated using therbs-railstoolsig/appare typeprof/RubyMine-generated and manually adaptedNOTE: Please do not review all the RBS files, and definitely ignore all the ones in the rbs-rails directory. If you really want to check stuff, look at the signatures in
sig/app.NOTE 2: I recommend updating to the latest ruby (3.2.2) and if you are using RubyMine, to the latest version (2023.2) as RBS is still in the process of becoming fully mature. The support and feedback from the tools is generally (significantly) better on the latest versions.