Fix .comment-meta width issue #1598
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the test failure one of the flaky tests addressed in #1569? I don't see how this tiny CSS change would cause that to fail on one single ruby version otherwise |
Yeah, judging by the error message, it's the flaky system tests, yeah, I'll rerun the pipeline shortly |
|
Oh, I just realized I've noticed the issue too and fixed it in my PR with fixes related to the button: 2e7578c. Not sure how to proceed, though, our fixes might be complementary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1558 introduced a
max-widthcondition that, for reasons I don't understand and likely never will, caused comment boxes to start underflowing:Fix verified in:
/thread/{id}/posts/{id}This PR fixes this bug. AFAIK, it has not been reported anywhere (yet).