Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloured output #47

Open
codingo opened this issue Oct 2, 2017 · 14 comments
Open

Coloured output #47

codingo opened this issue Oct 2, 2017 · 14 comments

Comments

@codingo
Copy link
Owner

codingo commented Oct 2, 2017

Update output to colourize output and improve feedback to the user. Will also require a --no-color to avoid coloured output.

@FrancescoSaverioZuppichini

I can try it :) Have you a colour scheme?

@codingo
Copy link
Owner Author

codingo commented Oct 2, 2017

Nothing in mind yet - do you want to base it off a *.json, *.txt or *.xml configuration file and it can be tweaked easily by the end user?

@FrancescoSaverioZuppichini

it can be a good idea! For now I will try to directly add colours in the code. As far as I understand, the main print is in virtual_host_scanner.py, am I correct?

@codingo
Copy link
Owner Author

codingo commented Oct 2, 2017

I think the main concern I have with static colours is the number of people in the infosec security using non-standard terminals. Maybe look at the sqlmap project for some implementation ideas? I'd say yellow at first.

The only two areas where output is only to the screen is the main print function in the virtual_host_scanner.py file and print_banner() in main. The other print statements are in the output helper class, but some work would need to be done to separate what's being written to file / written to screen to avoid the coloured output being written out to file.

@FrancescoSaverioZuppichini

I will take a look. I was thinking about using https://pypi.python.org/pypi/colored that should provide cross-platform support.

@codingo
Copy link
Owner Author

codingo commented Oct 2, 2017

Sounds good!

@codingo
Copy link
Owner Author

codingo commented Oct 4, 2017

Hey @FrancescoSaverioZuppichini! Just touching base to see how you're going with this one and if I can help in any way?

@FrancescoSaverioZuppichini

Hey, how are you?

This weekend I had some problem health problems, I will have time on the weekend :)

So you were suggesting to put the colours as NoSQLMap, so everything yellow, correct?

@codingo
Copy link
Owner Author

codingo commented Oct 11, 2017

Sorry @FrancescoSaverioZuppichini, I missed this comment - thinking red for errors, yellow for feedback, green for likely matches I'm thinking? If you want to wire something up we can tweak around with it in the pull request prior to a merge.

@codingo
Copy link
Owner Author

codingo commented Oct 21, 2017

@FrancescoSaverioZuppichini how'd you ever get on with this?

@aancw
Copy link
Contributor

aancw commented Apr 20, 2018

Are you still implementing this feature?

@codingo
Copy link
Owner Author

codingo commented Apr 20, 2018

Yes, would you like to take it? @timkent and I have been quite time poor for a while!

@aancw
Copy link
Contributor

aancw commented Apr 20, 2018

I've implemented basic color scheme output and logger for my project https://github.com/aancw/Belati
And not using print directly, but using log.console_log()

@codingo codingo self-assigned this May 15, 2018
@codingo
Copy link
Owner Author

codingo commented May 15, 2018

This has been outstanding for some time so moving to my own plate. I'll open a new branch for this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants