Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Line Colours #92

Closed
wants to merge 5 commits into from
Closed

Command Line Colours #92

wants to merge 5 commits into from

Conversation

codingo
Copy link
Owner

@codingo codingo commented May 17, 2018

This is the foundation for adding colours to the output of VHostScan as discussed in #47.

@codingo codingo self-assigned this May 17, 2018
@maxoja
Copy link

maxoja commented Sep 30, 2018

I want to try making this happen. Should I create a new pull request? Or how can I continue from what you have done?
I found a helpful reference for python3 : https://stackoverflow.com/questions/287871/print-in-terminal-with-colors

@codingo
Copy link
Owner Author

codingo commented Sep 30, 2018

Either is OK. A new one would be best if you're doing hacktoberfest so it properly counts towards your submissions.

@maxoja
Copy link

maxoja commented Sep 30, 2018

Either is OK. A new one would be best if you're doing hacktoberfest so it properly counts towards your submissions.

I will go ahead and create a new one
Thanks so much

@maxoja
Copy link

maxoja commented Sep 30, 2018

@codingo
It seems implementing this feature requires a module named termcolor which a user has to have it installed first. I suppose that I need to add a specific module name and version in requirements.txt. However, I am not confident that it will be all I have to do to update the dependency tree of your program. Anything else I should do?

@codingo
Copy link
Owner Author

codingo commented Oct 2, 2018

Closing as this is now in #103

@codingo codingo closed this Oct 2, 2018
@codingo codingo deleted the codingo-colours-integration branch October 2, 2018 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants