Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "tc-" Prefix to CSS Classes #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marvinscharle
Copy link

I changed the following css classes, prefixed them with "tc-table-drawer-" to avoid naming conflicts with other CSS class names.

  • table-selector -> tc-table-drawer-selector
  • table-row -> tc-table-drawer-row
  • table-cell-container -> tc-table-drawer-cell-container
  • table-cell -> tc-table-drawer-cell

Reason: The class names table-row is very generic and is very likely to produce naming conflicts with other style systems / JS modules. By adding the prefix tc-table-drawer- the name is more specific to this module, since other classes were already prefixed with tc- and therefore less likely to produce name conflicts.

- table-selector -> tc-table-drawer-selector
- table-row -> tc-table-drawer-row
- table-cell-container -> tc-table-drawer-cell-container
- table-cell -> tc-table-drawer-cell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants