1.3 'from future import url' doesn't work. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
It seems that smart-load-tag doesn't play well with 1.3's
{% from future import url %}tags.As far as I can tell, it's because of the ambiguity of the new syntax, and how it interacts with the smart-load-tag's conventions.
This pull fixes support with the 1.3 tag-style, but loses functionality. I don't consider it a good fix, but without it, django admin (or any apps that use future urls) don't work. I also try not to submit bugs without something useful as a pull :)
In any case, support for the future urls without losing functionality would be great. For my limited uses (mostly I'm using smart-load-tag for its namespaced imports), this works well.
Thanks!