Skip to content

Commit

Permalink
CDF-20144: remove wdl tests and mark deprecated (#856)
Browse files Browse the repository at this point in the history
wdl didn't hit GA and has no active usage through Scala SDK
and so no active usage through spark-datasource either.

Let's start by removing tests and marking deprecated.
Removing tests has a benefit of getting closer to being able
to run repo tests in any project (wdl tests can only be run in
dedicated projects with wdl access anyway).

[CDF-20144]
  • Loading branch information
dmivankov authored Nov 6, 2023
1 parent 6ba26b7 commit 671ffb1
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 329 deletions.
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ lazy val commonSettings = Seq(
organization := "com.cognite.spark.datasource",
organizationName := "Cognite",
organizationHomepage := Some(url("https://cognite.com")),
version := "3.4." + patchVersion,
version := "3.5." + patchVersion,
isSnapshot := patchVersion.endsWith("-SNAPSHOT"),
crossScalaVersions := supportedScalaVersions,
semanticdbEnabled := true,
Expand Down
1 change: 1 addition & 0 deletions src/main/scala/cognite/spark/v1/wdl/JsonObjectToRow.scala
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import io.circe.{Json, JsonObject}
import org.apache.spark.sql.Row
import org.apache.spark.sql.types._

@deprecated("wdl support is deprecated", since = "0")
object JsonObjectToRow {
implicit class RequiredOption[T](optionValue: Option[T]) {
def orThrow(structFieldName: String, nullable: Boolean, dataType: DataType): Option[T] =
Expand Down
1 change: 1 addition & 0 deletions src/main/scala/cognite/spark/v1/wdl/RowToJson.scala
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import java.time.{Instant, LocalDate}
import scala.collection.mutable

// sscalastyle:off
@deprecated("wdl support is deprecated", since = "0")
object RowToJson {

/**
Expand Down
2 changes: 2 additions & 0 deletions src/main/scala/cognite/spark/v1/wdl/WdlExceptions.scala
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ package cognite.spark.v1.wdl
import cognite.spark.v1.CdfSparkException
import org.apache.spark.sql.types.DataType

@deprecated("wdl support is deprecated", since = "0")
class RequiredFieldIsNullException(val structFieldName: String, val dataType: DataType)
extends CdfSparkException(
s"Required field `${structFieldName}` of type `${dataType.typeName}` should not be NULL.")

@deprecated("wdl support is deprecated", since = "0")
class WrongFieldTypeException(
val structFieldName: String,
val expectedDataType: DataType,
Expand Down
19 changes: 0 additions & 19 deletions src/test/scala/cognite/spark/v1/wdl/RowEquality.scala

This file was deleted.

243 changes: 0 additions & 243 deletions src/test/scala/cognite/spark/v1/wdl/RowToJsonTest.scala

This file was deleted.

66 changes: 0 additions & 66 deletions src/test/scala/cognite/spark/v1/wdl/WdlModelsTest.scala

This file was deleted.

0 comments on commit 671ffb1

Please sign in to comment.