-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filecontent: report itemsRead metric #1002
Conversation
Since filecontent doesn't go through `SdkV1Relation.{buildScan, getStream}` to implement reads read metrics weren't being automatically reported. Now it will do `itemsRead.inc()` once per line
Do you remember why we decided not to implement sdkV1relation? I vaguely remember discussing it but I don't remember the reasons for our decisions back then |
Nope, don't remember any specifics, maybe it doesn't provide suitable helpers or assumes more operations that filecontent supports? But could be something to look into |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 47 47
Lines 3156 3156
Branches 452 452
=======================================
Hits 2630 2630
Misses 526 526
|
Since filecontent doesn't go through
SdkV1Relation.{buildScan, getStream}
to implement readsread metrics weren't being automatically reported.
Now it will do
itemsRead.inc()
once per line