Check for null items in the delete iterator #842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 78.77% 78.77%
=======================================
Files 48 48
Lines 3016 3016
Branches 142 132 -10
=======================================
Hits 2376 2376
Misses 640 640
|
dmivankov
reviewed
Oct 16, 2023
| val deletes = rows.map(r => fromRow[DeleteItemByCogniteId](r)) | ||
| val deletes = rows | ||
| .map(fromRow[DeleteItemByCogniteId](_)) | ||
| .filter(_ != null) |
There was a problem hiding this comment.
I don't think pure exposed null is possible here, fromRow macro comes from here https://github.com/cognitedata/cdp-spark-datasource/blob/master/macro/src/main/scala/cognite/spark/compiletime/macros/SparkSchemaHelper.scala
And even it was it doesn't sound too clean to only handle it in this location & without diagnostics to indicate if or when it may happen.
VerstraeteBert
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.